Skip to content
This repository was archived by the owner on Feb 19, 2025. It is now read-only.

v5 - No Authentication needed #79

Closed
abacao opened this issue May 16, 2020 · 2 comments
Closed

v5 - No Authentication needed #79

abacao opened this issue May 16, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@abacao
Copy link

abacao commented May 16, 2020

Flutterhole doesn't show some data if pihole doesn't have a password and without token set in app.

This if fixed by setting the api token as "No password set" without quotes.

With this, Flutterhole has more data but it can't (for example) pause the pihole (error occurs).

Suggestion: if no token is set, use the token "No password set" to show all data in app and try to fix the error when trying to pause pihole action.

@sterrenb
Copy link
Owner

Hello @abacao 👋 - Thanks for opening an issue!

I wasn't aware this was possible, thank you for the suggestion. Sounds like something that can be implemented.

Currently, if no API token is set, no request is sent and a NotAuthenticatedPiException is thrown.

In order to prevent confusion regarding when/when not to use an API token, would it be an idea to add a checkbox saying something like "This Pi-hole has no password"? Enabling this could disable the API token input field.

@sterrenb sterrenb added the bug Something isn't working label May 16, 2020
@abacao
Copy link
Author

abacao commented May 16, 2020

Yes, the creation of a feature that enables the "no password" box may be a better approach if pihole changes the flow.

@sterrenb sterrenb mentioned this issue May 17, 2020
sterrenb added a commit that referenced this issue May 20, 2020
More verbose error logging

Adding drawer footer and better about dialog

Adding apiTokenRequired field, fixes #79
sterrenb added a commit that referenced this issue May 24, 2020
* Adding apiTokenRequired field, fixes #79

* Remove index shift from QueryStatus toJson/fromJson, fixes #82

* Adding query log page

* Adding queries over time chart

* Adding clients over time chart

* Searchable & refreshable query log/client/domain pages

* Status indicators in Pi-hole forms can be tapped to show error details

* More verbose error logging

* Adding drawer footer and better about dialog

* Adding DoubleBackToClose
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants