vvp: Don't schedule initial value propagation for net array ports #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An initial value propagation should only be scheduled for variable array ports, but not for net array port since those do not contain any values. This got accidentally broken when fixing support for 2-state variable array ports. Add a check that only does the initial value propagation if the port is for a variable array. Fixes: 0eb01ff ("vvp: Fix initial value propagation for 2-state non-automatic arrays") Signed-off-by: Lars-Peter Clausen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An initial value propagation should only be scheduled for variable array ports, but not for net array port since those do not contain any values.
This got accidentally broken when fixing support for 2-state variable array ports.
Add a check that only does the initial value propagation if the port is for a variable array.
Test case in #1014.