Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an option for ignoring errors about missing modules #151

Merged
merged 1 commit into from
Mar 22, 2017

Conversation

tumik
Copy link
Contributor

@tumik tumik commented Mar 21, 2017

This commit adds an option (-i) to ignore errors about missing modules.

Ignoring missing modules is really useful for using iverilog as linter in text editors (like Atom or Sublime Text), where you usually only want to check single files without caring about modules on other files.

@steveicarus steveicarus merged commit 02ed16a into steveicarus:master Mar 22, 2017
@steveicarus
Copy link
Owner

This looks fine and useful.

I am curious what happens when you use this flag in a non-linting situation.

@jersey99
Copy link
Contributor

Does seem really useful, and I gave this a try. However, if the missing file is included with an `include directive, ivlpp still errors out:

Include file xxx.vh not found

Not sure what the intended behavior in this case should be.

jfcherng added a commit to jfcherng-sublime/SublimeLinter-contrib-iverilog that referenced this pull request Jul 31, 2019
@jfcherng
Copy link

jfcherng commented Aug 5, 2019

@martinwhitaker I wonder can we have this PR included in the v10-branch as well? Currently it seems to be only in master. I just found that the iverilog package on Ubuntu does not have the -i flag which is quite useful for linter usage...

@martinwhitaker
Copy link
Collaborator

We don't normally add new features to the stable branch, but this seems safe enough.
@steveicarus , what do you think?

@jfcherng
Copy link

jfcherng commented Nov 2, 2019

@martinwhitaker @steveicarus sorry to re-ping on this but any chance to land it on v10?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants