Skip to content
This repository has been archived by the owner on May 20, 2020. It is now read-only.

Create flag-compatible infrastructure #215

Merged
merged 1 commit into from
Dec 31, 2017

Conversation

hjr3
Copy link
Contributor

@hjr3 hjr3 commented Dec 3, 2017

Adds infrastructure to become flag-compatible with existing rustdoc.
There are a few general buckets a flag falls into:

  1. Flag stays the same
  2. Flag is no longer supported in the new rustdoc
  3. Flag has moved (usually under a subcommand)

Most flags have still not been implemented and they will say so. Also,
some flags are in a limbo state where they are probably going to be
unsupported in the future. Until that decision has been declared, they
are marked as unimplemented.

BREAKING: This change moves -o from open flag to output flag.

@hjr3
Copy link
Contributor Author

hjr3 commented Dec 3, 2017

I spent some time thinking of a way to not have to declare the unsupported options and then have a separate list to check against them again. Everything I came up with added too much complexity to be worth it. If someone has an idea, I am all for it.

@steveklabnik
Copy link
Owner

Thanks! I can't give a real review until tomorrow, but this is failing due to lack of rustfmt.

@hjr3
Copy link
Contributor Author

hjr3 commented Dec 3, 2017

Hmm, I did not think the long strings would fail rustfmt. If I wrap them, it messes up the usage output. I will figure this out in a bit.

Adds infrastructure to become flag-compatible with existing rustdoc.
There are a few general buckets a flag falls into:

1. Flag stays the same
2. Flag is no longer supported in the new rustdoc
3. Flag has moved (usually under a subcommand)

Most flags have still not been implemented and they will say so. Also,
some flags are in a limbo state where they are probably going to be
unsupported in the future. Until that decision has been declared, they
are marked as unimplemented.

BREAKING: This change moves `-o` from open flag to output flag.
@steveklabnik steveklabnik merged commit 477d8bf into steveklabnik:master Dec 31, 2017
@steveklabnik
Copy link
Owner

I re-did the formatting for you. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants