Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

tkellogg
Copy link

For one, an exclusive lock was being held for far too long, so I shortened it some.

Also, the Published event wasn't being called for QoS 2, only for QoS1. I fixed that.

As a side note, I noticed that you're not actively developing this tool. I work for 2lemetry which is an m2m provider. I would be glad to take over this repository - I think we could ensure it's continued development even if I get bored of it.

@stevenlovegrove
Copy link
Owner

Thanks for these fixes. I've not been using .net for a while, so I just want to check - is Linq widely supported on other platforms (e.g. Mono) these days?

With regard to maintenance of this library, I would love to see it get more use and grow. You are welcome to maintain a public fork. Is that what you mean?

@tkellogg
Copy link
Author

Yeah, I'm not doing .NET either anymore, but I still care about it. I believe LINQ is fully supported in all profiles (there's no essentially no performance penalty). Mono supports everything up through C# 5. The only thing you have to be careful about is which Framework libs you use.

In the past when I've given people control over my repos, I just gave them push access and/or admin access (I can't remember if push access is the same thing as admin). In this case, I might entertain the idea of transferring the whole MqttDotNet repo to the m2mIO user (2lemetry). The main fork would then be located at https://github.com/m2mIO/MqttDotNet. It's up to you what you want to do.

@stevenlovegrove
Copy link
Owner

Okay, well lets just maintain a fork for now, and if it looks like 2lemetry
is contributing a lot of code we can think about transferring the repo.
Thanks again for your changes. I'm moving house right now but I'll test
them soon.

On Thursday, August 22, 2013, Tim Kellogg wrote:

Yeah, I'm not doing .NET either anymore, but I still care about it. I
believe LINQ is fully supported in all profiles (there's no essentially no
performance penalty). Mono supports everything up through C# 5. The only
thing you have to be careful about is which Framework libs you use.

In the past when I've given people control over my repos, I just gave them
push access and/or admin access (I can't remember if push access is the
same thing as admin). In this case, I might entertain the idea of
transferring the whole MqttDotNet repo to the m2mIO user (2lemetry). The
main fork would then be located at https://github.com/m2mIO/MqttDotNet.
It's up to you what you want to do.


Reply to this email directly or view it on GitHubhttps://github.com//pull/9#issuecomment-23112329
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants