add fine tuning #128
Merged
add fine tuning #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oerc0122
previously approved these changes
May 23, 2024
alinelena
reviewed
May 28, 2024
alinelena
reviewed
May 28, 2024
alinelena
reviewed
May 28, 2024
Co-authored-by: Alin Marin Elena <[email protected]>
alinelena
reviewed
May 28, 2024
alinelena
reviewed
May 28, 2024
Co-authored-by: Alin Marin Elena <[email protected]>
alinelena
approved these changes
May 28, 2024
alinelena
approved these changes
May 28, 2024
alinelena
previously approved these changes
May 28, 2024
Co-authored-by: ElliottKasoar <[email protected]>
oerc0122
previously approved these changes
May 29, 2024
Co-authored-by: ElliottKasoar <[email protected]>
ElliottKasoar
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #127
--fine_tune key added as an input for the train
CalcjobThe input validation checks that a model is given either in the config file or as an input.
in the config file, it can be anything (a string referring to some model types like "small" or a path to a model file)
If it is given as a
ModelDatainput, it has to be a file.This is in general a main difference between janus and aiida-mlip that I don't know if we want to keep like this or change (the problem being that
ModelDatais built to be a file, so if we want it to also be a string, I can either completely modify it or just allow an additional input that is an alternative to theModelDataand it is just a string)