-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor phonons #329
Merged
Merged
Refactor phonons #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alinelena
reviewed
Oct 11, 2024
I have attached two paths.yml we can still discuss the best way to have the info in.
|
6f491ca
to
c3236bf
Compare
b6df653
to
e6b9df1
Compare
alinelena
reviewed
Oct 24, 2024
this will need a rebase otherwise is fine with me |
alinelena
previously approved these changes
Oct 31, 2024
de14be7
to
06b333b
Compare
(Rebased) |
06b333b
to
130bcfa
Compare
oerc0122
reviewed
Nov 8, 2024
ElliottKasoar
commented
Nov 8, 2024
ElliottKasoar
commented
Nov 8, 2024
ElliottKasoar
commented
Nov 8, 2024
Co-authored-by: Jacob Wilkins <[email protected]>
8b9b8f0
to
15dfa87
Compare
oerc0122
approved these changes
Nov 8, 2024
alinelena
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #310
I think this addresses the remaining items, other than non-diagonal supercells, which will be covered by #320.
To do:
npoints
, rather than hard coded value?