Skip to content
/ fmtlib-fmt Public
forked from fmtlib/fmt
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix fmt::get for some GCC versions and legacy Clang (#2144) #165

Merged
merged 1 commit into from
Feb 23, 2021
Merged

fix fmt::get for some GCC versions and legacy Clang (#2144) #165

merged 1 commit into from
Feb 23, 2021

Conversation

sthagen
Copy link
Owner

@sthagen sthagen commented Feb 23, 2021

fixes fmtlib#2140

  • some GCC versions decay function pointers to const void*, exactly like
    MSVC does
  • legacy Clang (prior to 7.0) treats function pointers also as const T*
    pointers, but unable to convert them

I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.

@alexezeder
fix fmt::get for some GCC versions and legacy Clang (#2144)
d8e1c9f 
fixes #2140

- some GCC versions decay function pointers to `const void*`, exactly like
  MSVC does
- legacy Clang (prior to 7.0) treats function pointers also as `const T*`
  pointers, but unable to convert them
@sthagen sthagen merged commit 30c6615 into sthagen:master Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make error
2 participants
@sthagen @alexezeder