Fix scaling of last LED in page #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are 0xB4 (0x00 through 0xB3) LEDs/registers in the first page. Plus one for the scaling byte. Similar for the second page. Signed-off-by: Daniel Schaefer <[email protected]>
JohnAZoidberg
force-pushed
the
fix-b3
branch
from
7292848 to
5c19cdc
Compare
|
I just ran into an issue with two LEDs with seemingly dead blue channels on my 13x9 RGB display, and this is indeed the fix. I'll use your fork till this is merged, thanks @JohnAZoidberg! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 0xB4 (0x00 through 0xB3) LEDs/registers in the first page. Plus one for the scaling byte.
Similar for the second page.
My board has an LED at 0xB3 but not at 0xAA, so I tested only the former.