Move sanity checking to client-server interaction #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leastbad
added
proposal
ruby
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the difficulty/impossibility of comparing the gem + npm package versions in Rails 7 and beyond, it was clear that significant parts of the sanity checking module needed to be reengineered to work as part of the library operation (as opposed to a once-off app startup check).
While this is very much intended to be merged with its SR sibling, it is important that the CR patch be merged first.
Since there is no concept of the server calling the client in CR, you can test this by changing the npm package version and trying to run a Reflex. You should see an error in the Console Inspector.
Note: in a late innovation suggested by @marcoroth,
broadcastandbroadcast_tonow return recipient counts.