Add precompile_assets option to disable assets compilation
#631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR
Enhancement
Description
This pull request ports over the changes introduced in stimulusreflex/cable_ready#244
This allows developers to disable the assets pre-compilation step, which previously happened automatically if the gem was included and sprockets was installed in the app.
If the project is using esbuild/webpack/vite it's very likely that there's no need to precompile the StimulusReflex assets in your app.
Why should this be added
So that developers can turn off the pre-compilation step if they don't ship the StimulusReflex assets via the Asset pipeline.
Checklist