Return a hash with indifferent access rather than a Mash #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
1.0.0 resolved #25, but
Hashie::Mash
is very different from a regularHash
. This causes issues with some existing code. In particular,symbolize_keys
no longer works as expected.Solution
Instead of converting the Setting hash into a
Hashie::Mash
, instead convert returned values that would be aHash
into a newSettingHash
class. This is a normalHash
that has had some Hashie extensions added, notablyIndifferentAccess
.Note that if this gem depended on ActiveSupport, I would just call
.with_indifferent_access
rather than messing with Hashie. It might be worth discussing changing the dependency.