This repository has been archived by the owner on Mar 14, 2019. It is now read-only.
convert to puma, add circle, Dockerfile #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlambert121
force-pushed
the
circle_docker
branch
from
b15dc86 to
c348891
Compare
| on_worker_boot do | ||
| # Worker specific setup for Rails 4.1+ | ||
| # See: https://devcenter.heroku.com/articles/deploying-rails-applications-with-the-puma-web-server#on-worker-boot | ||
| if defined?(ActiveRecord::Base) |
There was a problem hiding this comment.
This app doesn't use a database, so this might not be needed.
There was a problem hiding this comment.
Hmm, though I can see it was in the unicorn config, so let's leave it for "changing less things"
There was a problem hiding this comment.
LOL, right. going to remove it
There was a problem hiding this comment.
Sorry, didn't see your second comment. Will leave it
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert unicorn -> puma
Add
circle.ymlAdd Dockerfile