This repository has been archived by the owner on Mar 14, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When we cannot connect to Redis, which is frequent with RedisCloud, the monitoring jobs fail. Since they are run periodically, there's no sense retrying them, so we end up with a lot of grinding.
Solution
Add option to log and ignore them.
Addendum
MonitorJob
had no test coverage, and adding it was tricky because it relies on a lot of global state. Thus, I sadly had to introduce a mocking library in order to get test coverage. With that coverage, I refactored the class to not create every single checker and notifier every single time, instead only creating what is needed. This change isn't strictly needed for this, but it allowed the tests to be a lot easier to deal with.