Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrapping doesn't work on sass // comments in Vue SFCs #309

Closed
symmetriq opened this issue Feb 1, 2022 · 5 comments
Closed

Wrapping doesn't work on sass // comments in Vue SFCs #309

symmetriq opened this issue Feb 1, 2022 · 5 comments

Comments

@symmetriq
Copy link

First, thank you for this incredibly useful extension! I use it constantly.

Here's the issue: Nothing happens when I try to wrap // sass comments in the <style> section of a .vue file. Wrapping works as expected on /* standard CSS comments */.

<style lang="scss">
// This is a really long comment that should definitely wrap but doesn't because wrapping is only supported for standard CSS comments

/* This comment will wrap just fine, even though it's really long and goes on for awhile, because it's a standard CSS comment. */
</style>

Wrapping // comments in regular .scss files works as expected.
@stkb
Copy link
Owner

stkb commented Feb 1, 2022

Yeah it's not smart enough to look at lang attributes yet. I'll just add // comments to CSS.

@symmetriq
Copy link
Author

That should do the trick. Thanks!

stkb added a commit that referenced this issue Feb 6, 2022
@stkb
CSS: Use the same processor as Java
c3e1139 
This is a temporary fix to enable using `//` comments in Sass in style
tags in html files (#309).
@stkb
Copy link
Owner

stkb commented Feb 6, 2022

This should now work in pre-release version 17.5

@stkb stkb added in pre-release version Is in pre-release version but not in stable yet and removed in-progress labels Feb 6, 2022
@symmetriq
Copy link
Author

Just tried it. It works. Thanks!

stkb added a commit that referenced this issue Feb 14, 2022
@stkb
CSS: Use the same processor as Java
4711db2 
This is a temporary fix to enable using `//` comments in Sass in style
tags in html files (#309).
stkb added a commit that referenced this issue Feb 14, 2022
@stkb
v1.16.2
bcabf34 
- Support .rmd files as markdown (#245)
- Basic support for Textile files as markdown (#271)
- Support FIDL (#255), Pascal/Delphi (#97) & pylintrc files (#121)
- Shell script: Ignore shebangs (#129)
- Add '//'-comments to CSS (workaround for #309)
- Fix batch files: case-insensitive "REM" and "@" prefix (#313)
- Fix the document being 'modified' if there were no actual changes
  (#308, #315)
@stkb
Copy link
Owner

stkb commented Feb 14, 2022

Now in stable v1.16.2 too.

@stkb stkb closed this as completed Feb 14, 2022
@stkb stkb removed the in pre-release version Is in pre-release version but not in stable yet label Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@symmetriq @stkb