Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mem write odd #730

Merged
merged 9 commits into from
Aug 1, 2018
Merged

Mem write odd #730

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c1abc8a
Use local variable for read_result instead of *ret, and fix
donmr Jul 26, 2018
185b02f
Merge branch 'master' of https://github.com/texane/stlink
donmr Jul 26, 2018
a20d499
Found a problem when reading an odd (%4) number of bytes at the end
donmr Jul 26, 2018
dc89eda
Fix Issues from Fabien-Chouteau's review of my previous patch in isue…
donmr Jul 27, 2018
9058556
Revert change to mem_write() so it does not confuse fixes to do_semih…
donmr Jul 27, 2018
44b3392
Add cast to avoid warning.
donmr Jul 27, 2018
49680dd
Restore change to mem_write to return immeadiately if len == 0.
donmr Jul 27, 2018
6f02484
Merge pull request #2 from texane/master
donmr Jul 28, 2018
e55a2d9
Remove cast of "-1" to uint32_t. It's now compared to a ssize_t
donmr Jul 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/gdbserver/semihosting.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,19 @@ static int mem_read(stlink_t *sl, uint32_t addr, void *data, uint16_t len)

static int mem_write(stlink_t *sl, uint32_t addr, void *data, uint16_t len)
{
// Note: this function can write more than it is asked to!
// If addr is not an even 32 bit boundary, or len is not a multiple of 4.
//
// If only 32 bit values can be written to the target,
// then this function should read the target memory at the
// start and end of the buffer where it will write more that
// the requested bytes. (perhaps reading the whole area is faster??).
//
// If 16 and 8 bit writes are available, then they could be used instead.

// Just return when the length is zero avoiding unneeded work.
if (len == 0) return 0;

int offset = addr % 4;
int write_len = len + offset;

Expand Down Expand Up @@ -341,7 +354,7 @@ int do_semihosting (stlink_t *sl, uint32_t r0, uint32_t r1, uint32_t *ret) {
read_result = read(fd, buffer, buffer_len);
saved_errno = errno;

if (read_result == (uint32_t)-1) {
if (read_result == -1) {
*ret = buffer_len;
} else {
if (mem_write(sl, buffer_address, buffer, read_result) != 0 ) {
Expand Down