remap enums #462
Merged
remap enums #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burrbull
force-pushed
the
maps
branch
3 times, most recently
from
01cec99 to
27d0358
Compare
burrbull
force-pushed
the
maps
branch
3 times, most recently
from
838e3ca to
9f026a1
Compare
therealprof
approved these changes
Jul 29, 2023
burrbull
force-pushed
the
maps
branch
5 times, most recently
from
f6a9d2b to
08f199d
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is breaking change.
It uses similar idea to stm32-rs/stm32f4xx-hal#594 and family, but different.
Istead of
pins: TupleOfPinEnumsperipheral keepspins: EnumOfPinTupleCombinations. It is less beautiful and flexible, but gives workaround forAFIOmap issues (which is F1 only).Needs complex testing. cc @all_who_can_test_and_have_ideas :)