fix no route in ocp 311 and errors in log #468
Conversation
Signed-off-by: Zhiwei Yin <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
|
/assign @qiujian16 |
| @@ -1,4 +1,5 @@ | |||
| --- | |||
| {{- if not (eq .Values.product "") }} | |||
There was a problem hiding this comment.
not quite sure why this is needed, we do not create service when product is empty?
There was a problem hiding this comment.
the previous logic is that we create LoadBalancer service firstly and then update the service to ClusterIP when the product claim is OCP added by work-manager addon .
for OCP 311, work-agent will meet error to update the service invalid: spec.ports[0].nodePort: Forbidden: may not be used when type is 'ClusterIP' because this issue kubernetes/kubectl#221 has not fixed in old k8s.
current fix is that to create service until the product claim is appended to the managedCluster. will not need to update the service.
There was a problem hiding this comment.
it means we will not create service in *ks clusters since we cannot know the product? is this desired?
There was a problem hiding this comment.
no, the product claim will be Other for *ks, not empty.
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, zhiweiyin318 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Zhiwei Yin [email protected]
fix issue: https://github.com/stolostron/backlog/issues/21853
OCP 311 has route, support to get log using route.
fix issue: https://github.com/stolostron/backlog/issues/21554
work-agent cannot update service if the type of service is changed in OCP 311, and return error
invalid: spec.ports[0].nodePort: Forbidden: may not be used whentypeis 'ClusterIP'this is an issue in old k8s version, has been fixed in new one. Unable to change service from type=NodePort to type=ClusterIP with kubectl kubernetes/kubectl#221
the fix in addon is that deploy service until the product claim has value. will not update it in addon manifestwork.
return error for the interface of the imageRegisty Client to help debug.