Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump x/net and x/crypto #155

Merged

Conversation

saswatamcode
Copy link
Member

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

@openshift-ci openshift-ci bot added the approved label Jan 8, 2025
@saswatamcode
Copy link
Member Author

/cherry-pick release-2.12 release-2.11 release-2.10 release-2.9

@openshift-cherrypick-robot

@saswatamcode: once the present PR merges, I will cherry-pick it on top of release-2.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.12 release-2.11 release-2.10 release-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

@philipgough philipgough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Jan 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: philipgough, saswatamcode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [philipgough,saswatamcode]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Saswata Mukherjee <[email protected]>
@subbarao-meduri subbarao-meduri force-pushed the upgrade_go_x_net_crypto branch from 2d0e013 to d36adf8 Compare January 10, 2025 14:49
Copy link

openshift-ci bot commented Jan 10, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm label Jan 10, 2025
@philipgough
Copy link

@subbarao-meduri did you force push something, Im wondering why these tests are failing for the go mod change ?

@subbarao-meduri subbarao-meduri merged commit 73c97a2 into stolostron:release-2.13 Jan 10, 2025
13 of 18 checks passed
@openshift-cherrypick-robot

@saswatamcode: new pull request could not be created: failed to create pull request against stolostron/thanos#release-2.12 from head openshift-cherrypick-robot:cherry-pick-155-to-release-2.12: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between stolostron:release-2.12 and openshift-cherrypick-robot:cherry-pick-155-to-release-2.12"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to this:

/cherry-pick release-2.12 release-2.11 release-2.10 release-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants