Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tianmu):set sql_mode=MANDATORY_TIANMU,Cannot create stored routine xxx. Check warnings(#1065) #1069

Merged
merged 1 commit into from
Dec 6, 2022
Merged

fix(tianmu):set sql_mode=MANDATORY_TIANMU,Cannot create stored routine xxx. Check warnings(#1065) #1069

merged 1 commit into from
Dec 6, 2022

Conversation

konghaiya
Copy link
Collaborator

@konghaiya konghaiya commented Dec 5, 2022 •
edited
Loading

NOTE: When adding new SQL_MODE types, make sure to also add them to
the scripts used for creating the MySQL system tables
in scripts/mysql_system_tables.sql and scripts/mysql_system_tables_fix.sql

Summary about this PR

Issue Number: close #1065

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Dec 5, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label Dec 5, 2022
@codecov
Copy link

codecov bot commented Dec 5, 2022 •
edited
Loading

Codecov Report

Base: 0.00% // Head: 33.78% // Increases project coverage by +33.78% 🎉

Coverage data is based on head (f44787b) compared to base (3c8a5b5).
Patch has no changes to coverable lines.

❗ Current head f44787b differs from pull request most recent head 053f37c. Consider uploading reports for the commit 053f37c to get more accurate results

Additional details and impacted files 
@@                 Coverage Diff                  @@
##           stonedb-5.7-dev    #1069       +/-   ##
====================================================
+ Coverage                 0   33.78%   +33.78%     
====================================================
  Files                    0     1807     +1807     
  Lines                    0   394958   +394958     
====================================================
+ Hits                     0   133421   +133421     
- Misses                   0   261537   +261537
Impacted Files Coverage Δ
include/mysql/psi/mysql_memory.h 100.00% <0.00%> (ø)
storage/csv/ha_tina.cc 8.58% <0.00%> (ø)
storage/innobase/include/row0upd.ic 26.19% <0.00%> (ø)
...obuf-2.6.1/src/google/protobuf/unknown_field_set.h 33.33% <0.00%> (ø)
sql/sql_plugin.cc 41.34% <0.00%> (ø)
storage/tianmu/core/filter_block.cpp 40.65% <0.00%> (ø)
regex/reginit.c 95.74% <0.00%> (ø)
strings/str_alloc.c 0.00% <0.00%> (ø)
sql/sp_head.cc 87.46% <0.00%> (ø)
storage/tianmu/vc/subselect_column.cpp 44.56% <0.00%> (ø)
... and 1797 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

RingsC
RingsC approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@RingsC RingsC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lujiashun
lujiashun approved these changes Dec 6, 2022
View reviewed changes
Copy link

@lujiashun lujiashun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify
Copy link
Contributor

mergify bot commented Dec 6, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot merged commit e395f89 into stoneatom:stonedb-5.7-dev Dec 6, 2022
@konghaiya
fix(tianmu):set sql_mode=MANDATORY_TIANMU,Cannot create stored routin…
053f37c 
…e xxx. Check warnings(stoneatom#1065)

NOTE: When adding new SQL_MODE types, make sure to also add them to
      the scripts used for creating the MySQL system tables
      in scripts/mysql_system_tables.sql and scripts/mysql_system_tables_fix.sql
@konghaiya konghaiya deleted the dev_lhj_1065 branch December 13, 2022 09:24
@Nliver Nliver added this to the StoneDB_5.7_v1.0.2 milestone Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lujiashun lujiashun lujiashun approved these changes

@RingsC RingsC RingsC approved these changes

@hustjieke hustjieke Awaiting requested review from hustjieke

@duanfuxiang0 duanfuxiang0 Awaiting requested review from duanfuxiang0

@isredstar isredstar Awaiting requested review from isredstar

Assignees

@konghaiya konghaiya

Labels
PR-bug bug for pull request
Projects
StoneDB for MySQL 5.7
Status: Done
Milestone
StoneDB_5.7_v1.0.2
Development

Successfully merging this pull request may close these issues.

bug: Stored procedures cannot be created if the value of sql_mode includes variable mandatory_tianmu.
4 participants
@konghaiya @RingsC @lujiashun @Nliver