Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tianmu): fix alter table add column not null.(#1188) #1235

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

DandreChen
Copy link
Collaborator

Summary about this PR

Issue Number: close #1188
[summary]
Convert alter table add column not null to use copy algorithm.

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@DandreChen DandreChen self-assigned this Jan 17, 2023
@mergify
Copy link
Contributor

mergify bot commented Jan 17, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label Jan 17, 2023
@lujiashun
Copy link

lujiashun commented Jan 17, 2023

This PR is similar with #1208 , the implementations is different, We can only choose one, @DandreChen @wisehead @hustjieke

@DandreChen DandreChen marked this pull request as draft February 2, 2023 06:57
@DandreChen DandreChen marked this pull request as ready for review February 3, 2023 03:01
@DandreChen DandreChen force-pushed the stonedb-5.7-dev branch 3 times, most recently from 0c346f6 to dd43d0a Compare February 3, 2023 03:18
@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Base: 0.00% // Head: 43.15% // Increases project coverage by +43.15% 🎉

Coverage data is based on head (a96673a) compared to base (fd5c85f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@                 Coverage Diff                  @@
##           stonedb-5.7-dev    #1235       +/-   ##
====================================================
+ Coverage                 0   43.15%   +43.15%     
====================================================
  Files                    0     1830     +1830     
  Lines                    0   396271   +396271     
====================================================
+ Hits                     0   171010   +171010     
- Misses                   0   225261   +225261     
Impacted Files Coverage Δ
storage/tianmu/handler/ha_tianmu.h 81.25% <ø> (ø)
storage/tianmu/handler/ha_tianmu.cpp 56.20% <100.00%> (ø)
sql/sys_vars.h 36.97% <0.00%> (ø)
storage/perfschema/pfs_setup_object.cc 64.03% <0.00%> (ø)
....1/src/google/protobuf/compiler/cpp/cpp_helpers.cc 78.00% <0.00%> (ø)
sql/sql_class.h 70.93% <0.00%> (ø)
mysys/my_malloc.c 82.45% <0.00%> (ø)
storage/tianmu/core/compilation_tools.cpp 46.95% <0.00%> (ø)
sql/table_trigger_field_support.h 0.00% <0.00%> (ø)
storage/innobase/include/trx0undo.ic 100.00% <0.00%> (ø)
... and 1822 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DandreChen DandreChen force-pushed the stonedb-5.7-dev branch 3 times, most recently from bb64ae8 to 6a3b0fb Compare February 9, 2023 06:10
@DandreChen DandreChen force-pushed the stonedb-5.7-dev branch 2 times, most recently from 8de6910 to 4d25f55 Compare February 14, 2023 02:45
Convert alter table add column not null to use copy algorithm.
Copy link

@lujiashun lujiashun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 36fbc22 into stoneatom:stonedb-5.7-dev Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-bug bug for pull request
Projects
Development

Successfully merging this pull request may close these issues.

bug: ERROR 1105 (HY000): assert failed on cur_pack != nullptr at tianmu_attr.cpp:401, msg: [Pack ptr is null]
4 participants