Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tianmu): fix endless loop occurs during data_cache (#1352) #1353

Merged
merged 2 commits into from
Mar 6, 2023
Merged

fix(tianmu): fix endless loop occurs during data_cache (#1352) #1353

merged 2 commits into from
Mar 6, 2023

Conversation

adofsauron
Copy link
Collaborator

@adofsauron adofsauron commented Mar 3, 2023

1. The CACHE_ITEM type does not recurse by making a direct comparison
2. When two referenced variables have the same address,
    they are considered to be the same value

Summary about this PR

Issue Number: close #1352

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Mar 3, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label Mar 3, 2023
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (7e3d1cd) 43.12% compared to head (91705f0) 43.14%.

❗ Current head 91705f0 differs from pull request most recent head f31b760. Consider uploading reports for the commit f31b760 to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                 @@
##           stonedb-5.7-dev    #1353      +/-   ##
===================================================
+ Coverage            43.12%   43.14%   +0.02%     
===================================================
  Files                 1830     1830              
  Lines               396395   396392       -3     
===================================================
+ Hits                170935   171020      +85     
+ Misses              225460   225372      -88     
Impacted Files Coverage Δ
storage/tianmu/core/mysql_expression.cpp 86.73% <0.00%> (-0.14%) ⬇️
storage/tianmu/compress/range_code.h 73.45% <0.00%> (-1.10%) ⬇️
storage/innobase/os/os0event.cc 78.01% <0.00%> (-0.71%) ⬇️
storage/tianmu/compress/top_bit_dict.cpp 66.15% <0.00%> (-0.66%) ⬇️
storage/innobase/btr/btr0sea.cc 74.81% <0.00%> (-0.37%) ⬇️
storage/perfschema/pfs_instr.cc 63.26% <0.00%> (-0.25%) ⬇️
storage/innobase/row/row0sel.cc 63.25% <0.00%> (-0.18%) ⬇️
strings/str2int.c 78.78% <0.00%> (ø)
storage/innobase/include/ib0mutex.h 71.82% <0.00%> (ø)
... and 21 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

    1. The CACHE_ITEM type does not recurse by making a direct comparison
    2. When two referenced variables have the same address,
        they are considered to be the same value
Copy link
Collaborator

@hustjieke hustjieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 4105e58 into stoneatom:stonedb-5.7-dev Mar 6, 2023
@Nliver Nliver added this to the StoneDB_5.7_v1.0.2 milestone Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-bug bug for pull request
Projects
Development

Successfully merging this pull request may close these issues.

bug: Relevant resources are not released after a thread is killed.
5 participants