Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sql,tianmu):fix when binlog format is row, the load data statement cannot be recorded(#1876) #1906

Merged
merged 1 commit into from
Jun 30, 2023
Merged

fix(sql,tianmu):fix when binlog format is row, the load data statement cannot be recorded(#1876) #1906

merged 1 commit into from
Jun 30, 2023

Conversation

chenshengjiang
Copy link
Collaborator

Summary about this PR

  1. Actually, tianmu uses its own code to handle load which lacks support of row format of binlog
  2. When tianmu parsing rows, write table map event first
  3. Once tianmu constructs a row, just add it to the rows log event, when parsing is done, the rows log event will also be ready, then write it to the binlog

Issue Number: close #1876

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Jun 25, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label Jun 25, 2023
@chenshengjiang chenshengjiang force-pushed the issue1876 branch 3 times, most recently from 56a9557 to a7e2e49 Compare June 30, 2023 05:39
@chenshengjiang
fix(sql,tianmu):fix when binlog format is row, the load data statemen…
0f2dcfd 
…t cannot be recorded(stoneatom#1876)

1. Actually, tianmu uses its own code to handle load which lacks support of row format of binlog
2. When tianmu parsing rows,  write table map event first
3. Once tianmu constructs a row, just add it to the rows log event, when parsing is done,
the rows log event will also be ready, then write it to the binlog
zhongshengstoneatom
zhongshengstoneatom approved these changes Jun 30, 2023
View reviewed changes
Copy link

@zhongshengstoneatom zhongshengstoneatom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

RingsC
RingsC approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@RingsC RingsC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice job

@mergify mergify bot merged commit 69213ff into stoneatom:stonedb-5.7-dev Jun 30, 2023
@chenshengjiang chenshengjiang deleted the issue1876 branch June 30, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhongshengstoneatom zhongshengstoneatom zhongshengstoneatom approved these changes

@haitaoguan haitaoguan haitaoguan approved these changes

@RingsC RingsC RingsC approved these changes

Assignees

@chenshengjiang chenshengjiang

Labels
PR-bug bug for pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: When the format of binlog is row, the load data statement cannot be recorded.
4 participants
@chenshengjiang @RingsC @haitaoguan @zhongshengstoneatom