-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tianmu): fix query syntax (WHERE NOT IN ) is not supported. (#767) #912
fix(tianmu): fix query syntax (WHERE NOT IN ) is not supported. (#767) #912
Conversation
Thanks for the contribution! Please review the labels and make any necessary changes. |
|
c40dc17
to
f566a1b
Compare
|
f566a1b
to
578fb3a
Compare
The result set is incorrect in the clause dependent subquery
|
96407c7
to
9a249c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9a249c6
to
091a67a
Compare
…eatom#767) [summary] 1 'sub_select' item is the left argument,not the right argument of 'item_func'; 2 5.7 use 'item_func_not' class to represent the meaning of the syntax "not", while 8.0 use a variable 'value_transform'; 3 porting new join code from 5.7 for this case; 3.1 solve throwing exception ”select * from t1 where val not in (select * from t2 where val2 >= 10);" 4 porting ChooseJoinAlgorithm from 5.7 for this case; 4.1 solve incorrect result set for some sql in the mtr(which one is forgotton...) 5 porting ResetToTemplate modification from 5.7 for this case; 5.1 solve incorrect result set "select * from t1 where val not in (select * from t2 where val2 > t1.val);"
091a67a
to
89744ad
Compare
Summary about this PR
Issue Number: ref #767
[summary]
1 'sub_select' item is the left argument,not the right argument of 'item_func';
2 5.7 use 'item_func_not' class to represent the meaning of the syntax "not", while 8.0 use a variable 'value_transform';
3 porting new join code from 5.7 for this case;
3.1 solve throwing exception ”select * from t1 where val not in (select * from t2 where val2 >= 10);“
4 porting ChooseJoinAlgorithm from 5.7 for this case;
4.1 solve incorrect result set for some sql in the mtr(which one is forgotton...)
5 porting ResetToTemplate modification from 5.7 for this case;
5.1 solve incorrect result set "select * from t1 where val not in (select * from t2 where val2 > t1.val);"
Tests Check List
Changelog
Documentation