Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(yaml): change severity of YAMLIncomaptibleValue diagnostics #1009

Merged
merged 1 commit into from
Mar 12, 2020
Merged

fix(yaml): change severity of YAMLIncomaptibleValue diagnostics #1009

merged 1 commit into from
Mar 12, 2020

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Mar 11, 2020

Improves #955

Requires stoplightio/yaml#39

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

@P0lip P0lip added t/bug Something isn't working WIP labels Mar 11, 2020
@P0lip P0lip self-assigned this Mar 11, 2020
@P0lip P0lip force-pushed the fix/yaml-severity branch from 80af863 to a97417d Compare March 11, 2020 13:23
@P0lip P0lip force-pushed the fix/yaml-severity branch from a97417d to 555db49 Compare March 11, 2020 14:56
@P0lip P0lip removed the WIP label Mar 11, 2020
@P0lip P0lip marked this pull request as ready for review March 11, 2020 14:56
@P0lip P0lip requested a review from nulltoken March 11, 2020 14:57
@nulltoken
Copy link
Contributor

@P0lip Raising a Warning is a good enough compromise for now. Good call and good job!

@P0lip P0lip merged commit daa99e6 into develop Mar 12, 2020
@nulltoken nulltoken deleted the fix/yaml-severity branch March 14, 2020 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nulltoken nulltoken nulltoken approved these changes

Assignees

@P0lip P0lip

Labels
t/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@P0lip @nulltoken