-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rulesets): require node_module #1029
Conversation
@P0lip This PR triggers a warning during the building of the Spectral binary:
|
@P0lip Regarding the warning that pkg spits out, shouldn't we find a way to fail the build when that happens? |
Yeah, same on my end. Shouldn't be harmful though. It's due to that |
So your thoughts are: "If the test harness works ok, then the binary should have been properly packaged"? Good enough for me. |
@P0lip LGTM |
I tested the binary manually as well. |
Fixes #1026
Checklist
Does this PR introduce a breaking change?