Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rulesets): load custom functions from npm #1093

Merged
merged 4 commits into from
Apr 15, 2020
Merged

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Apr 14, 2020

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

@P0lip P0lip added t/bug Something isn't working documentation labels Apr 14, 2020
@P0lip P0lip requested review from philsturgeon and nulltoken April 14, 2020 20:05
@P0lip P0lip self-assigned this Apr 14, 2020
Copy link
Contributor

@philsturgeon philsturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me!

@P0lip P0lip requested review from philsturgeon and nulltoken April 15, 2020 14:32
@P0lip P0lip merged commit 53bb823 into develop Apr 15, 2020
@P0lip P0lip deleted the docs/npm-ruleset branch April 15, 2020 21:06
Copy link
Contributor

@nulltoken nulltoken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

if (typeof targetVal !== 'number') {
return [
{
message: 'Value is not a number.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@P0lip Great!

@nulltoken
Copy link
Contributor

@P0lip Awesome doc work and great examples!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation t/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants