Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ruleset): drop useless oas rule tags #1095

Merged
merged 1 commit into from
Apr 15, 2020
Merged

chore(ruleset): drop useless oas rule tags #1095

merged 1 commit into from
Apr 15, 2020

Conversation

nulltoken
Copy link
Contributor

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

Following a discussion in #974 about tags in rulesets, it's been realized that they're no longer used and may even be a bit confusing would someone want to get some inspiration from the oas ruleset in order to write his/her own.

Let's provide those tags a very well deserved freedom in the Great Recycle Land of Bits.

@nulltoken nulltoken requested review from philsturgeon and P0lip April 15, 2020 13:22
philsturgeon
philsturgeon previously approved these changes Apr 15, 2020
philsturgeon
philsturgeon previously approved these changes Apr 15, 2020
Copy link
Contributor

@P0lip P0lip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually hold on, make sure to update types too.

@nulltoken
Copy link
Contributor Author

Actually hold on, make sure to update types too

@P0lip Oh! You're right. I forgot about them.

They're now fixed.

Copy link
Contributor

@P0lip P0lip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@P0lip P0lip merged commit 3041eaa into stoplightio:develop Apr 15, 2020
@nulltoken nulltoken deleted the ntk/drop_tags branch April 15, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants