perf: minor tweaks to core functions #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P0lip
force-pushed
the
perf/core-functions
branch
from
fd3e70d to
5ee3e0d
Compare
|
LGTM! Could you also update the doco describing how to build custom functions to match this recommended code writing pattern? |
nulltoken
previously approved these changes
May 26, 2020
|
@nulltoken added! |
nulltoken
reviewed
May 27, 2020
nulltoken
previously approved these changes
May 27, 2020
Co-authored-by: nulltoken <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A subset of changes from #1136.
I'm planning to merge it post 5.4.
Checklist
Does this PR introduce a breaking change?
Additional context
A few minor tweaks, mostly to avoid allocation of arrays that are never needed for most of the time.
At the moment, plenty of core functions allocate an array even if no actual validation is to take place due to invalid data, etc.
This causes unnecessary GC churn in case of larger specs, because these functions are called very often - thousands of times in some circumstances.
One unrelated change - moved the validation of
reusableObjectsLocationto schema.