feat(oas): merge example rules

[P0lip]

This is a follow-up PR.
See #1284 (comment) for the reasoning.

tl;dr we no longer need such granular rules, as given can be an array of paths now.

Checklist

• Tests added / updated
• Docs added / updated

Does this PR introduce a breaking change?

• Yes
• No

[nulltoken]

@P0lip Great job! One thought though. There are a lot of code duplication among the tests, and some tests exist in some file and not in others (format related ones IIRC for instance).

What would you think of extracting the valid/invalid schemas and the matching props of the results we'd like to check in one global collection, and then "inject" the schemas in proper locations of base documents in each test? We may have to tweak the expectations regarding the resulting paths, but it's possible this would greatly reduce the size of the diff and (maybe) make those tests a bit easier to maintain and reason about?

[P0lip]

Agree re duplication. It bothers me too.

What would you think of extracting the valid/invalid schemas and the matching props of the results we'd like to check in one global collection, and then "inject" the schemas in proper locations of base documents in each test?

Hm, not sure I'm following. What do you exactly suggest?

[philsturgeon]

There's a few approaches to avoid duplication:

1. jest.each
2. defining common schema in a context (outside of it()) and just tweaking it a bit for each one, instead of redefining the whole thing
3. make some "fixture files"

I'm usually quite content with 1 or 2 but 3 can lead to awkward changes when multiple people do different things with the fixtures.

Also keep in mind we don't need to fix this now, if we keep on boy scouting as we go it'll get better over time.

[nulltoken]

@P0lip My thoughts were around a combination of @philsturgeon points 1 & 2. However, I'm also fine with the we don't need to fix this now, if we keep on boy scouting as we go it'll get better over time way. You've done a tremendous job and maybe refactoring the examples would just deserve a neat issue to keep track of it

[P0lip]

@nulltoken @philsturgeon alright, did some deduplication.
We could probably do a little bit more here and there, but it should be already much better