Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): JUnit formatter respects fail-severity #1375

Merged
merged 3 commits into from
Oct 6, 2020

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Oct 5, 2020

Fixes #935 and the lack of choices as reported in #935 (comment) by @fgabolde

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

@P0lip P0lip added the t/bug Something isn't working label Oct 5, 2020
@P0lip P0lip requested a review from philsturgeon October 5, 2020 11:51
@P0lip P0lip self-assigned this Oct 5, 2020
philsturgeon
philsturgeon previously approved these changes Oct 5, 2020
Copy link
Contributor

@philsturgeon philsturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but please check with the folks reporting the issue so see if it works for them.

@P0lip P0lip merged commit 66e241b into develop Oct 6, 2020
@P0lip P0lip deleted the fix/junit-fail-severity branch October 6, 2020 10:52
P0lip added a commit that referenced this pull request Nov 1, 2020
* fix(cli): list format choices

* fix(cli): junit respects fail-severity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warnings are not being shown in junit output
2 participants