feat(formatters): added pretty formatter for colored and wrapped cli output #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amthorn
force-pushed
the
pretty_formatter
branch
from
c2cf692 to
0923828
Compare
amthorn
force-pushed
the
pretty_formatter
branch
from
0923828 to
cdd8720
Compare
roubles
previously approved these changes
Apr 19, 2021
P0lip
previously approved these changes
Apr 22, 2021
Committing PR review suggestions:) Co-authored-by: Jakub Rożek <[email protected]>
|
@P0lip commited your requested changes:) thanks! ran yarn lint + yarn test again. All looks good. Thanks for letting me contribute:) |
P0lip
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Does this PR introduce a breaking change?
Screenshots
Complex Wrapping:
With Stylish:
With Pretty:
Additional context
I've added this due to the stylish formatter being somewhat rough on certain terminals based on their terminal width and based on the spec file. For some very long spec files, the paths and line numbers are longer than the expected terminal width. Additionally, the colors are very subtle and easy to miss. It's often difficult to read and doesn't wrap appropriately (See screenshot above of the comparison of stylish to pretty)