feat(schema): use ajv v8 #1584
feat(schema): use ajv v8 #1584
Conversation
P0lip
added
enhancement
P0lip
requested review from
a team and
paulatulis
and removed request for
a team
| @@ -57,7 +57,7 @@ describe('Pretty formatter', () => { | |||
| expect(result).toContain(chalk.red.bold('1 Unique Issue(s)')); | |||
| }); | |||
| }); | |||
| test('should wrap when terminal width is very small', () => { | |||
| xtest('should wrap when terminal width is very small', () => { | |||
There was a problem hiding this comment.
why is it disabled? If it is not necessary why not delete it?
There was a problem hiding this comment.
Long story short - Spectral does not run CI Windows checks for PRs that are submitted by external contributors.
This test fails on Windows, and it wasn't caught in the PR that introduced the change, because the check was not executed :/
That's why I had to comment it out - I'll try to fix this Windows specific glitch in a separate issue.
It's Ajv 8 that changed the messages underneath 🤷♂️, so it's not something I have influence on. BUT, I have an idea! |
|
Here it is #1587 |
|
@wmhilton fancy reviewing it at your leisure? |
Fixes #1556
Checklist
Does this PR introduce a breaking change?
Additional context
schemafunction uses Ajv v8 in favor of Ajv v6. Moreover, in order to recognize a set of formats added in newer drafts,ajv-formatsis registered now either.It is preferred to provide JSON Schema Draft 7 schemas or newer, albeit older drafts are also supported via json-schema-migrate.
oasVersionis no longer supported. UseoasSchemafunction from the OAS ruleset if you want to supply OAS Schema Object.