-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: consistent paths in messages #867
Conversation
4679de6
to
7cf4062
Compare
@marbemac @philsturgeon |
If I had to guess at the use case for people who want the whole path, they are probably using it programmatically do if we make it available in the object (and it can be inserted into the message string via a {{path}} variable) then both JS and CLI users should be happy. Then we can keep it property whenever possible by default.
…On Mon, Dec 23, 2019 at 13:56, Jakub Rożek ***@***.***> wrote:
***@***.***(https://github.com/marbemac) ***@***.***(https://github.com/philsturgeon)
the last remaining question is whether we are making paths configurable - right now we always try to display the property name, but some want to have the whole path printed.
What do you think?
—
You are receiving this because you were mentioned.
Reply to this email directly, [view it on GitHub](#867?email_source=notifications&email_token=AAAQONOHU7MENJVEUIF7ZJDQ2CYP7A5CNFSM4J5FZ4QKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHRCD7Y#issuecomment-568467967), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAAQONO5TB4AHKKHJ7APZLLQ2CYP7ANCNFSM4J5FZ4QA).
|
Suggest we punt this to later - not convinced we need it so might as well save the time now :). |
We do expose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good to me 👍.
Addresses #815
Checklist
Does this PR introduce a breaking change?