Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate proper paths for rules operating on unresolved documents #900

Merged
merged 3 commits into from
Jan 13, 2020

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Jan 9, 2020

Fixes #891

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

@P0lip P0lip added the t/bug Something isn't working label Jan 9, 2020
@P0lip P0lip self-assigned this Jan 9, 2020
@nulltoken
Copy link
Contributor

@P0lip Awesome!

nulltoken
nulltoken previously approved these changes Jan 13, 2020
@P0lip P0lip force-pushed the fix/unresolved-documents branch from a5b4761 to 3003326 Compare January 13, 2020 17:04
@P0lip P0lip requested a review from nulltoken January 13, 2020 17:05
@P0lip
Copy link
Contributor Author

P0lip commented Jan 13, 2020

(had conflicts)

Copy link
Contributor

@nulltoken nulltoken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@P0lip P0lip merged commit 4437c86 into develop Jan 13, 2020
@P0lip P0lip deleted the fix/unresolved-documents branch January 13, 2020 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid medata when running an rule applying to an unresolved document referenced over http
2 participants