feat(dumping): support lineWidth #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billiegoose
previously requested changes
Sep 9, 2019
package.json
Outdated
| "lodash": "^4.17.15", | ||
| "yaml-ast-parser": "~0.0.43" | ||
| "yaml-ast-parser": "stoplightio/yaml-ast-parser#ba8043e2eb7b444789a424754935f991572c25a1" |
There was a problem hiding this comment.
uh... shouldn't we publish it?
There was a problem hiding this comment.
marbemac
approved these changes
Sep 18, 2019
There was a problem hiding this comment.
Approved, just need to update to use https://www.npmjs.com/package/@stoplight/yaml-ast-parser?activeTab=versions.
…#25) * fix: do not report duplicate keys errors for keys added by merge keys * test: extra override scenario
|
🎉 This PR is included in version 3.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will 'fix' https://github.com/stoplightio/studio/issues/68.
To me, the above is not really an issue.
If we make this change, others might start complaining about the need of supporting folded block scalar style.
That said, it's still useful to have
lineWidthworking. I had to make a fork though, yet will try to make a PR out of it to make it land on upstream.