fix: do not report duplicate keys errors for keys added by merge keys #25
Conversation
| ignoreDuplicateKeys: false, | ||
| }); | ||
|
|
||
| expect(result.diagnostics).toEqual([]); |
There was a problem hiding this comment.
@P0lip In order to protect this from potential future regressions, isn't there a way to also assess the expected result of the merges?
There was a problem hiding this comment.
Yeah, I'll add such an assertion for sure, before I mark it as ready for review, no worries.
Just in case you were concerned, we already have a few tests covering merge keys :)
yaml/src/__tests__/parseWithPointers.spec.ts
Line 343 in f8b2298
I just didn't cover diagnostics. :P
There was a problem hiding this comment.
@nulltoken just in case you were interested, a test case has been added.
Thanks for providing an excellent fixture I could use right away. :)
There was a problem hiding this comment.
@nulltoken just in case you were interested, a test case has been added.
|
🎉 This PR is included in version 3.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
…#25) * fix: do not report duplicate keys errors for keys added by merge keys * test: extra override scenario
* feat(dumping): support lineWidth * fix: do not report duplicate keys errors for keys added by merge keys (#25) * fix: do not report duplicate keys errors for keys added by merge keys * test: extra override scenario * chore: use @stoplight/yaml-ast-parser
Fixes stoplightio/spectral#552