feat!: refactor upload-api #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View stack outputs
|
|
I have no idea why do test runner here says or how to fix it. I'm not sure why does it even expects |
Gozala
added a commit
to storacha/w3up
that referenced
this pull request
Mar 8, 2023
This PR makes changes needed for storacha/w3infra#154 namely: 1. Fixes type mappings in `package.json`, otherwise TS is confused in w3infra. 2. Removes obsolete `index.js` file that lives in w3infra now. 3. Exports types so they can be used from w3infra. 4. Updates return type from `undefined` to `null` to match what w3infra implementation returns.
|
🙏 please next time submit formatting changes as a separate PR to make reviewing easier. |
alanshaw
approved these changes
Mar 8, 2023
vasco-santos
reviewed
Mar 8, 2023
|
Can we next time have formatting changes in a new PR and discussed please? 🙏🏼 We previously agreed and decided to not use |
3 tasks
gobengo
pushed a commit
to storacha/w3up
that referenced
this pull request
Apr 11, 2023
This PR makes changes needed for storacha/w3infra#154 namely: 1. Fixes type mappings in `package.json`, otherwise TS is confused in w3infra. 2. Removes obsolete `index.js` file that lives in w3infra now. 3. Exports types so they can be used from w3infra. 4. Updates return type from `undefined` to `null` to match what w3infra implementation returns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on storacha/w3up#504, which will require release and update here. With local symlink it works as expected.