access-api should respond to `space/info` invocations for space dids not in its db with a well-defined error result type #382

gobengo · 2023-01-20T23:25:41Z

Motivation:

enable clients to better distinguish when a space is not found by space/info handler. Right now they would have to parse an error message. With this they can just look at result.status === 404 to check for this case.
enable upload-api to distinguish when this happens proposal: store/add handler should have more helpful error when trying to invoke against space that has not had email confirmed w3infra#134 (upload-api calls space/info inside its verifyInvocation helper)

Unblocks

part of implementation of proposal: store/add handler should have more helpful error when trying to invoke against space that has not had email confirmed w3infra#134

The text was updated successfully, but these errors were encountered:

…ure with name (#391) Motivation: * implement #382 * tl;dr `space/info` now has explicit failure type for case where the ucans are valid, but the space DID is not in the db. that way when upload-api invokes `space/info` as part of its `verifyInvocation` logic, it can distinguish between an invalid invocation and a not-found space id Unblocks: * this test passing gobengo/w3protocol-test#1 * rest of storacha/w3infra#134 (comment)

gobengo · 2023-01-31T21:38:47Z

tested via gobengo/w3protocol-test#1

…ure with name (#391) Motivation: * implement #382 * tl;dr `space/info` now has explicit failure type for case where the ucans are valid, but the space DID is not in the db. that way when upload-api invokes `space/info` as part of its `verifyInvocation` logic, it can distinguish between an invalid invocation and a not-found space id Unblocks: * this test passing gobengo/w3protocol-test#1 * rest of storacha/w3infra#134 (comment)

🤖 I have created a release *beep* *boop* --- ## [4.0.0](storacha/w3ui@uploader-core-v3.0.2...uploader-core-v4.0.0) (2023-02-16) no real breaking changes, but a major version bump because release-please got confused by my mistakes. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

gobengo mentioned this issue Jan 20, 2023

proposal: store/add handler should have more helpful error when trying to invoke against space that has not had email confirmed storacha/w3infra#134

Closed

3 tasks

gobengo transferred this issue from storacha/w3infra Jan 20, 2023

This was referenced Jan 21, 2023

Add test for space/info delegation gobengo/w3protocol-test#1

Merged

feat: access-api handling store/info for space not in db returns failure with name #391

Merged

gobengo closed this as completed Jan 31, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

access-api should respond to `space/info` invocations for space dids not in its db with a well-defined error result type #382

access-api should respond to `space/info` invocations for space dids not in its db with a well-defined error result type #382

gobengo commented Jan 20, 2023 •

edited

Loading

gobengo commented Jan 31, 2023

access-api should respond to space/info invocations for space dids not in its db with a well-defined error result type #382

access-api should respond to space/info invocations for space dids not in its db with a well-defined error result type #382

Comments

gobengo commented Jan 20, 2023 • edited Loading

gobengo commented Jan 31, 2023

access-api should respond to `space/info` invocations for space dids not in its db with a well-defined error result type #382

access-api should respond to `space/info` invocations for space dids not in its db with a well-defined error result type #382

gobengo commented Jan 20, 2023 •

edited

Loading