Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipe invocations and results into w3infra #581

Closed
Gozala opened this issue Mar 21, 2023 · 0 comments · Fixed by #592
Closed

Pipe invocations and results into w3infra #581

Gozala opened this issue Mar 21, 2023 · 0 comments · Fixed by #592
Assignees
Milestone

Comments

@Gozala
Copy link
Contributor

Gozala commented Mar 21, 2023

We need to hook invocations and their results into #579

@Gozala Gozala added this to the w3up phase 3 milestone Mar 21, 2023
@Gozala Gozala self-assigned this Mar 21, 2023
alanshaw pushed a commit that referenced this issue Mar 23, 2023
Fixes #581 

## Overview

- Integrates changes from #579
  - I have added `undici` to [pnpm overrides](https://pnpm.io/package_json)
- Gets rid of `raw` route in favor of `root` which now uses decoder/encoder based of content type
- Defines `UCANLog` interface for sending invocations & receipts to kenisis
   - As per #579 we probably want to use CF Queue for failure tolerance which can be a followup improvement
- Type fixes to unblock some changes
   - You can't do `@implements {import('./bindings').UCANLog}` nor you can type alias and do implements because it no longer an interface. Solution is to do `import * as API from "./bindings.js"` in which case you can `@implements {API.UCANLog}`, which is why end up changing `bindings.d.ts` to `bindings.ts` + `bindings.js`.
   - Turns out `.d.ts` files aren't type checked so ☝️ uncovered bunch of errors I had to fix

## Notes

- I'm not happy how this reaches deep into ucanto & I'd like to uplift changes around encode / decode / execute into ucanto. Once that is done I'll make a followup change here to replace some of these with ucanto exposed functionality
   - It also would make it easier to integrate things in the upload-api
- I do not seem to have privileges to add vars and secrets in this, so someone with enough privileges should add `UCAN_LOG_URL` or` UCAN_LOG_BASIC_AUTH` so someone needs to do it to make this work.
- I end up sending invocations and receipts to the same endpoint but different content-type header which I think makes sense.
   - Also unlike #579 I've decided to decouple endpoint from upload endpoint as they're logically unrelated.
gobengo pushed a commit that referenced this issue Apr 11, 2023
Fixes #581 

## Overview

- Integrates changes from #579
  - I have added `undici` to [pnpm overrides](https://pnpm.io/package_json)
- Gets rid of `raw` route in favor of `root` which now uses decoder/encoder based of content type
- Defines `UCANLog` interface for sending invocations & receipts to kenisis
   - As per #579 we probably want to use CF Queue for failure tolerance which can be a followup improvement
- Type fixes to unblock some changes
   - You can't do `@implements {import('./bindings').UCANLog}` nor you can type alias and do implements because it no longer an interface. Solution is to do `import * as API from "./bindings.js"` in which case you can `@implements {API.UCANLog}`, which is why end up changing `bindings.d.ts` to `bindings.ts` + `bindings.js`.
   - Turns out `.d.ts` files aren't type checked so ☝️ uncovered bunch of errors I had to fix

## Notes

- I'm not happy how this reaches deep into ucanto & I'd like to uplift changes around encode / decode / execute into ucanto. Once that is done I'll make a followup change here to replace some of these with ucanto exposed functionality
   - It also would make it easier to integrate things in the upload-api
- I do not seem to have privileges to add vars and secrets in this, so someone with enough privileges should add `UCAN_LOG_URL` or` UCAN_LOG_BASIC_AUTH` so someone needs to do it to make this work.
- I end up sending invocations and receipts to the same endpoint but different content-type header which I think makes sense.
   - Also unlike #579 I've decided to decouple endpoint from upload endpoint as they're logically unrelated.
Peeja pushed a commit to storacha/upload-service that referenced this issue Jan 17, 2025
per storacha/w3ui#295 rework the keyring
to use w3up-client rather than the lower level access library

I'd like to refactor these APIs soon, but for now I'm keeping them
unchanged to minimize downstream changes

I am releasing this as a breaking change - I don't think anything will
break, but would prefer to let downstream users opt in to this
Peeja pushed a commit to storacha/upload-service that referenced this issue Jan 17, 2025
🤖 I have created a release *beep* *boop*
---


##
[6.0.0](storacha/w3ui@keyring-core-v5.1.0...keyring-core-v6.0.0)
(2023-11-20)


### ⚠ BREAKING CHANGES

* use w3up-client in keyring
([storacha#581](storacha/w3ui#581))

### Features

* use w3up-client in keyring
([storacha#581](storacha/w3ui#581))
([bd5f341](storacha/w3ui@bd5f341))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Peeja pushed a commit to storacha/upload-service that referenced this issue Jan 17, 2025
🤖 I have created a release *beep* *boop*
---


##
[7.0.0](storacha/w3ui@uploader-core-v6.1.0...uploader-core-v7.0.0)
(2023-11-21)


### ⚠ BREAKING CHANGES

* use w3up-client in keyring
([storacha#581](storacha/w3ui#581))

### Features

* use w3up-client in keyring
([storacha#581](storacha/w3ui#581))
([bd5f341](storacha/w3ui@bd5f341))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Peeja pushed a commit to storacha/upload-service that referenced this issue Jan 17, 2025
🤖 I have created a release *beep* *boop*
---


##
[5.0.0](storacha/w3ui@uploads-list-core-v4.1.0...uploads-list-core-v5.0.0)
(2023-11-21)


### ⚠ BREAKING CHANGES

* use w3up-client in keyring
([storacha#581](storacha/w3ui#581))

### Features

* use w3up-client in keyring
([storacha#581](storacha/w3ui#581))
([bd5f341](storacha/w3ui@bd5f341))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <[email protected]>
Peeja pushed a commit to storacha/upload-service that referenced this issue Jan 17, 2025
🤖 I have created a release *beep* *boop*
---


##
[7.0.0](storacha/w3ui@react-keyring-v6.2.1...react-keyring-v7.0.0)
(2023-11-21)


### ⚠ BREAKING CHANGES

* use w3up-client in keyring
([storacha#581](storacha/w3ui#581))

### Features

* use w3up-client in keyring
([storacha#581](storacha/w3ui#581))
([bd5f341](storacha/w3ui@bd5f341))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Alan Shaw <[email protected]>
Peeja pushed a commit to storacha/upload-service that referenced this issue Jan 17, 2025
🤖 I have created a release *beep* *boop*
---


##
[6.0.0](storacha/w3ui@solid-keyring-v5.0.1...solid-keyring-v6.0.0)
(2023-11-21)


### ⚠ BREAKING CHANGES

* use w3up-client in keyring
([storacha#581](storacha/w3ui#581))

### Features

* add support for getting an account's plan
([storacha#564](storacha/w3ui#564))
([11023a4](storacha/w3ui@11023a4))
* re-export Service from `react-keyring`
([storacha#577](storacha/w3ui#577))
([308816d](storacha/w3ui@308816d))
* use w3up-client in keyring
([storacha#581](storacha/w3ui#581))
([bd5f341](storacha/w3ui@bd5f341))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <[email protected]>
Peeja pushed a commit to storacha/upload-service that referenced this issue Jan 17, 2025
🤖 I have created a release *beep* *boop*
---


##
[6.0.0](storacha/w3ui@vue-keyring-v5.0.1...vue-keyring-v6.0.0)
(2023-11-21)


### ⚠ BREAKING CHANGES

* use w3up-client in keyring
([storacha#581](storacha/w3ui#581))

### Features

* add support for getting an account's plan
([storacha#564](storacha/w3ui#564))
([11023a4](storacha/w3ui@11023a4))
* re-export Service from `react-keyring`
([storacha#577](storacha/w3ui#577))
([308816d](storacha/w3ui@308816d))
* use w3up-client in keyring
([storacha#581](storacha/w3ui#581))
([bd5f341](storacha/w3ui@bd5f341))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <[email protected]>
Peeja pushed a commit to storacha/upload-service that referenced this issue Jan 29, 2025
per storacha/w3ui#295 rework the keyring
to use w3up-client rather than the lower level access library

I'd like to refactor these APIs soon, but for now I'm keeping them
unchanged to minimize downstream changes

I am releasing this as a breaking change - I don't think anything will
break, but would prefer to let downstream users opt in to this
Peeja pushed a commit to storacha/upload-service that referenced this issue Jan 29, 2025
🤖 I have created a release *beep* *boop*
---


##
[6.0.0](storacha/w3ui@keyring-core-v5.1.0...keyring-core-v6.0.0)
(2023-11-20)


### ⚠ BREAKING CHANGES

* use w3up-client in keyring
([storacha#581](storacha/w3ui#581))

### Features

* use w3up-client in keyring
([storacha#581](storacha/w3ui#581))
([2edddd9](storacha/w3ui@2edddd9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Peeja pushed a commit to storacha/upload-service that referenced this issue Jan 29, 2025
🤖 I have created a release *beep* *boop*
---


##
[7.0.0](storacha/w3ui@uploader-core-v6.1.0...uploader-core-v7.0.0)
(2023-11-21)


### ⚠ BREAKING CHANGES

* use w3up-client in keyring
([storacha#581](storacha/w3ui#581))

### Features

* use w3up-client in keyring
([storacha#581](storacha/w3ui#581))
([2edddd9](storacha/w3ui@2edddd9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Peeja pushed a commit to storacha/upload-service that referenced this issue Jan 29, 2025
🤖 I have created a release *beep* *boop*
---


##
[5.0.0](storacha/w3ui@uploads-list-core-v4.1.0...uploads-list-core-v5.0.0)
(2023-11-21)


### ⚠ BREAKING CHANGES

* use w3up-client in keyring
([storacha#581](storacha/w3ui#581))

### Features

* use w3up-client in keyring
([storacha#581](storacha/w3ui#581))
([2edddd9](storacha/w3ui@2edddd9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <[email protected]>
Peeja pushed a commit to storacha/upload-service that referenced this issue Jan 29, 2025
🤖 I have created a release *beep* *boop*
---


##
[7.0.0](storacha/w3ui@react-keyring-v6.2.1...react-keyring-v7.0.0)
(2023-11-21)


### ⚠ BREAKING CHANGES

* use w3up-client in keyring
([storacha#581](storacha/w3ui#581))

### Features

* use w3up-client in keyring
([storacha#581](storacha/w3ui#581))
([2edddd9](storacha/w3ui@2edddd9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Alan Shaw <[email protected]>
Peeja pushed a commit to storacha/upload-service that referenced this issue Jan 29, 2025
🤖 I have created a release *beep* *boop*
---


##
[6.0.0](storacha/w3ui@solid-keyring-v5.0.1...solid-keyring-v6.0.0)
(2023-11-21)


### ⚠ BREAKING CHANGES

* use w3up-client in keyring
([storacha#581](storacha/w3ui#581))

### Features

* add support for getting an account's plan
([storacha#564](storacha/w3ui#564))
([9565452](storacha/w3ui@9565452))
* re-export Service from `react-keyring`
([storacha#577](storacha/w3ui#577))
([94e8b96](storacha/w3ui@94e8b96))
* use w3up-client in keyring
([storacha#581](storacha/w3ui#581))
([2edddd9](storacha/w3ui@2edddd9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <[email protected]>
Peeja pushed a commit to storacha/upload-service that referenced this issue Jan 29, 2025
🤖 I have created a release *beep* *boop*
---


##
[6.0.0](storacha/w3ui@vue-keyring-v5.0.1...vue-keyring-v6.0.0)
(2023-11-21)


### ⚠ BREAKING CHANGES

* use w3up-client in keyring
([storacha#581](storacha/w3ui#581))

### Features

* add support for getting an account's plan
([storacha#564](storacha/w3ui#564))
([9565452](storacha/w3ui@9565452))
* re-export Service from `react-keyring`
([storacha#577](storacha/w3ui#577))
([94e8b96](storacha/w3ui@94e8b96))
* use w3up-client in keyring
([storacha#581](storacha/w3ui#581))
([2edddd9](storacha/w3ui@2edddd9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant