Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unecessary awaits #352

Merged
merged 1 commit into from
Jan 17, 2023
Merged

fix: remove unecessary awaits #352

merged 1 commit into from
Jan 17, 2023

Conversation

hugomrdias
Copy link
Contributor

No description provided.

vasco-santos
vasco-santos approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hugomrdias hugomrdias merged commit 64da6e5 into main Jan 17, 2023
@hugomrdias hugomrdias deleted the fix/caps-and-async branch January 17, 2023 18:25
@hugomrdias hugomrdias mentioned this pull request Jan 17, 2023
Merged
hugomrdias added a commit that referenced this pull request Jan 31, 2023
@hugomrdias
chore(main): release access 9.3.0 (#346)
fc53a16 
🤖 I have created a release *beep* *boop*
---


##
[9.3.0](access-v9.2.0...access-v9.3.0)
(2023-01-30)


### Features

* access-api forwards store/ and upload/ invocations to upload-api
([#334](#334))
([b773376](b773376))
* access-api handling store/info for space not in db returns failure
with name
([#391](#391))
([9610fcf](9610fcf))
* update @ucanto/* to ~4.2.3
([#405](#405))
([50c0c80](50c0c80))
* update access-api ucanto proxy to not need a signer
([#390](#390))
([71cbeb7](71cbeb7))


### Bug Fixes

* remove unecessary awaits
([#352](#352))
([64da6e5](64da6e5))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
gobengo pushed a commit that referenced this pull request Apr 11, 2023
@hugomrdias
fix: remove unecessary awaits (#352)
2e8c1a1
gobengo pushed a commit that referenced this pull request Apr 11, 2023
@hugomrdias
chore(main): release access 9.3.0 (#346)
83b3070 
🤖 I have created a release *beep* *boop*
---


##
[9.3.0](access-v9.2.0...access-v9.3.0)
(2023-01-30)


### Features

* access-api forwards store/ and upload/ invocations to upload-api
([#334](#334))
([6be7217](6be7217))
* access-api handling store/info for space not in db returns failure
with name
([#391](#391))
([665dac9](665dac9))
* update @ucanto/* to ~4.2.3
([#405](#405))
([ec39443](ec39443))
* update access-api ucanto proxy to not need a signer
([#390](#390))
([163fb74](163fb74))


### Bug Fixes

* remove unecessary awaits
([#352](#352))
([2e8c1a1](2e8c1a1))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 17, 2025
@olizilla
fix: remove authenticator class when registed (storacha#352)
3668f3b 
only include the `w3ui-authenticator` class in the dom when we want to
show the log in box.

otherwise the layout we choose for the register form is inherited by the
logged in app layout which is undesirable

fixes storacha/w3ui#351

License: MIT
Signed-off-by: Oli Evans <[email protected]>
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 17, 2025
@github-actions
chore(main): release w3console 1.0.0 (storacha#416)
5650893 
🤖 I have created a release *beep* *boop*
---


## 1.0.0 (2023-03-23)


### ⚠ BREAKING CHANGES

* use new account model
([storacha#400](storacha/w3ui#400))

### Features

* add terms of service page
([storacha#417](storacha/w3ui#417))
([6deb24d](storacha/w3ui@6deb24d))
* adds space-finder autocomplete combobox
([storacha#268](storacha/w3ui#268))
([3dcd647](storacha/w3ui@3dcd647))
* allow users to set page size in W3APIProvider
([storacha#308](storacha/w3ui#308))
([814a293](storacha/w3ui@814a293))
* club tropical w3 auth boxen
([storacha#350](storacha/w3ui#350))
([2266eb2](storacha/w3ui@2266eb2))
* delegate access to spaces
([storacha#293](storacha/w3ui#293))
([441d757](storacha/w3ui@441d757))
* import a space into w3console
([storacha#309](storacha/w3ui#309))
([a69a95b](storacha/w3ui@a69a95b))
* Improve upload component flow
([storacha#285](storacha/w3ui#285))
([ba9a3bf](storacha/w3ui@ba9a3bf))
* publish console to IPFS & Cloudflare from CI
([storacha#287](storacha/w3ui#287))
([e2a833e](storacha/w3ui@e2a833e))
* Storybook story improvements
([storacha#294](storacha/w3ui#294))
([e0de2cc](storacha/w3ui@e0de2cc))
* use new account model
([storacha#400](storacha/w3ui#400))
([66dd20b](storacha/w3ui@66dd20b))
* w3console example app
([storacha#255](storacha/w3ui#255))
([df08029](storacha/w3ui@df08029))


### Bug Fixes

* add _headers ([storacha#418](storacha/w3ui#418))
([4eb1da1](storacha/w3ui@4eb1da1))
* fix w3console styling
([storacha#320](storacha/w3ui#320))
([74a298c](storacha/w3ui@74a298c))
* remove authenticator class when registed
([storacha#352](storacha/w3ui#352))
([3668f3b](storacha/w3ui@3668f3b))
* w3console polish
([storacha#284](storacha/w3ui#284))
([9a67365](storacha/w3ui@9a67365))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 17, 2025
@github-actions
chore(main): release react 1.0.0 (storacha#593)
3df195d 
🤖 I have created a release *beep* *boop*
---


## 1.0.0 (2023-11-28)


### Features

* adds space-finder autocomplete combobox
([storacha#268](storacha/w3ui#268))
([3dcd647](storacha/w3ui@3dcd647))
* allow users to set page size in W3APIProvider
([storacha#308](storacha/w3ui#308))
([814a293](storacha/w3ui@814a293))
* club tropical w3 auth boxen
([storacha#350](storacha/w3ui#350))
([2266eb2](storacha/w3ui@2266eb2))
* Customizable UI components
([storacha#208](storacha/w3ui#208))
([0a776fe](storacha/w3ui@0a776fe))
* implement reverse paging
([storacha#381](storacha/w3ui#381))
([10f059a](storacha/w3ui@10f059a))
* Improve upload component flow
([storacha#285](storacha/w3ui#285))
([ba9a3bf](storacha/w3ui@ba9a3bf))
* simplify ([storacha#591](storacha/w3ui#591))
([d1dfdf0](storacha/w3ui@d1dfdf0))
* Storybook story improvements
([storacha#294](storacha/w3ui#294))
([e0de2cc](storacha/w3ui@e0de2cc))


### Bug Fixes

* fix w3console styling
([storacha#320](storacha/w3ui#320))
([74a298c](storacha/w3ui@74a298c))
* remove authenticator class when registed
([storacha#352](storacha/w3ui#352))
([3668f3b](storacha/w3ui@3668f3b))
* w3console polish
([storacha#284](storacha/w3ui#284))
([9a67365](storacha/w3ui@9a67365))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Alan Shaw <[email protected]>
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 17, 2025
@github-actions
chore(main): release react 1.2.0 (storacha#601)
af4b819 
🤖 I have created a release *beep* *boop*
---


##
[1.2.0](storacha/w3ui@react-v1.1.1...react-v1.2.0)
(2023-11-30)


### Features

* add a logout function
([storacha#595](storacha/w3ui#595))
([0995fd5](storacha/w3ui@0995fd5))
* adds space-finder autocomplete combobox
([storacha#268](storacha/w3ui#268))
([3dcd647](storacha/w3ui@3dcd647))
* allow users to set page size in W3APIProvider
([storacha#308](storacha/w3ui#308))
([814a293](storacha/w3ui@814a293))
* club tropical w3 auth boxen
([storacha#350](storacha/w3ui#350))
([2266eb2](storacha/w3ui@2266eb2))
* Customizable UI components
([storacha#208](storacha/w3ui#208))
([0a776fe](storacha/w3ui@0a776fe))
* implement reverse paging
([storacha#381](storacha/w3ui#381))
([10f059a](storacha/w3ui@10f059a))
* Improve upload component flow
([storacha#285](storacha/w3ui#285))
([ba9a3bf](storacha/w3ui@ba9a3bf))
* simplify ([storacha#591](storacha/w3ui#591))
([d1dfdf0](storacha/w3ui@d1dfdf0))
* Storybook story improvements
([storacha#294](storacha/w3ui#294))
([e0de2cc](storacha/w3ui@e0de2cc))


### Bug Fixes

* fix w3console styling
([storacha#320](storacha/w3ui#320))
([74a298c](storacha/w3ui@74a298c))
* homepage URL in package.json
([1229119](storacha/w3ui@1229119))
* remove authenticator class when registed
([storacha#352](storacha/w3ui#352))
([3668f3b](storacha/w3ui@3668f3b))
* w3console polish
([storacha#284](storacha/w3ui#284))
([9a67365](storacha/w3ui@9a67365))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 29, 2025
@olizilla
fix: remove authenticator class when registed (storacha#352)
e115f9f 
only include the `w3ui-authenticator` class in the dom when we want to
show the log in box.

otherwise the layout we choose for the register form is inherited by the
logged in app layout which is undesirable

fixes storacha/w3ui#351

License: MIT
Signed-off-by: Oli Evans <[email protected]>
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 29, 2025
@github-actions
chore(main): release w3console 1.0.0 (storacha#416)
dfdceac 
🤖 I have created a release *beep* *boop*
---


## 1.0.0 (2023-03-23)


### ⚠ BREAKING CHANGES

* use new account model
([storacha#400](storacha/w3ui#400))

### Features

* add terms of service page
([storacha#417](storacha/w3ui#417))
([e216efd](storacha/w3ui@e216efd))
* adds space-finder autocomplete combobox
([storacha#268](storacha/w3ui#268))
([5894cdc](storacha/w3ui@5894cdc))
* allow users to set page size in W3APIProvider
([storacha#308](storacha/w3ui#308))
([22d917a](storacha/w3ui@22d917a))
* club tropical w3 auth boxen
([storacha#350](storacha/w3ui#350))
([92fa065](storacha/w3ui@92fa065))
* delegate access to spaces
([storacha#293](storacha/w3ui#293))
([d99c96c](storacha/w3ui@d99c96c))
* import a space into w3console
([storacha#309](storacha/w3ui#309))
([f9df8a8](storacha/w3ui@f9df8a8))
* Improve upload component flow
([storacha#285](storacha/w3ui#285))
([4f5cf4f](storacha/w3ui@4f5cf4f))
* publish console to IPFS & Cloudflare from CI
([storacha#287](storacha/w3ui#287))
([df4715a](storacha/w3ui@df4715a))
* Storybook story improvements
([storacha#294](storacha/w3ui#294))
([c031ff7](storacha/w3ui@c031ff7))
* use new account model
([storacha#400](storacha/w3ui#400))
([b594536](storacha/w3ui@b594536))
* w3console example app
([storacha#255](storacha/w3ui#255))
([fbcdc42](storacha/w3ui@fbcdc42))


### Bug Fixes

* add _headers ([storacha#418](storacha/w3ui#418))
([625199d](storacha/w3ui@625199d))
* fix w3console styling
([storacha#320](storacha/w3ui#320))
([31cbe91](storacha/w3ui@31cbe91))
* remove authenticator class when registed
([storacha#352](storacha/w3ui#352))
([e115f9f](storacha/w3ui@e115f9f))
* w3console polish
([storacha#284](storacha/w3ui#284))
([654d507](storacha/w3ui@654d507))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 29, 2025
@github-actions
chore(main): release react 1.0.0 (storacha#593)
eea7020 
🤖 I have created a release *beep* *boop*
---


## 1.0.0 (2023-11-28)


### Features

* adds space-finder autocomplete combobox
([storacha#268](storacha/w3ui#268))
([5894cdc](storacha/w3ui@5894cdc))
* allow users to set page size in W3APIProvider
([storacha#308](storacha/w3ui#308))
([22d917a](storacha/w3ui@22d917a))
* club tropical w3 auth boxen
([storacha#350](storacha/w3ui#350))
([92fa065](storacha/w3ui@92fa065))
* Customizable UI components
([storacha#208](storacha/w3ui#208))
([1107544](storacha/w3ui@1107544))
* implement reverse paging
([storacha#381](storacha/w3ui#381))
([0077b34](storacha/w3ui@0077b34))
* Improve upload component flow
([storacha#285](storacha/w3ui#285))
([4f5cf4f](storacha/w3ui@4f5cf4f))
* simplify ([storacha#591](storacha/w3ui#591))
([7309e1d](storacha/w3ui@7309e1d))
* Storybook story improvements
([storacha#294](storacha/w3ui#294))
([c031ff7](storacha/w3ui@c031ff7))


### Bug Fixes

* fix w3console styling
([storacha#320](storacha/w3ui#320))
([31cbe91](storacha/w3ui@31cbe91))
* remove authenticator class when registed
([storacha#352](storacha/w3ui#352))
([e115f9f](storacha/w3ui@e115f9f))
* w3console polish
([storacha#284](storacha/w3ui#284))
([654d507](storacha/w3ui@654d507))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Alan Shaw <[email protected]>
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 29, 2025
@github-actions
chore(main): release react 1.2.0 (storacha#601)
a8cc650 
🤖 I have created a release *beep* *boop*
---


##
[1.2.0](storacha/w3ui@react-v1.1.1...react-v1.2.0)
(2023-11-30)


### Features

* add a logout function
([storacha#595](storacha/w3ui#595))
([3cd276b](storacha/w3ui@3cd276b))
* adds space-finder autocomplete combobox
([storacha#268](storacha/w3ui#268))
([5894cdc](storacha/w3ui@5894cdc))
* allow users to set page size in W3APIProvider
([storacha#308](storacha/w3ui#308))
([22d917a](storacha/w3ui@22d917a))
* club tropical w3 auth boxen
([storacha#350](storacha/w3ui#350))
([92fa065](storacha/w3ui@92fa065))
* Customizable UI components
([storacha#208](storacha/w3ui#208))
([1107544](storacha/w3ui@1107544))
* implement reverse paging
([storacha#381](storacha/w3ui#381))
([0077b34](storacha/w3ui@0077b34))
* Improve upload component flow
([storacha#285](storacha/w3ui#285))
([4f5cf4f](storacha/w3ui@4f5cf4f))
* simplify ([storacha#591](storacha/w3ui#591))
([7309e1d](storacha/w3ui@7309e1d))
* Storybook story improvements
([storacha#294](storacha/w3ui#294))
([c031ff7](storacha/w3ui@c031ff7))


### Bug Fixes

* fix w3console styling
([storacha#320](storacha/w3ui#320))
([31cbe91](storacha/w3ui@31cbe91))
* homepage URL in package.json
([5f8b616](storacha/w3ui@5f8b616))
* remove authenticator class when registed
([storacha#352](storacha/w3ui#352))
([e115f9f](storacha/w3ui@e115f9f))
* w3console polish
([storacha#284](storacha/w3ui#284))
([654d507](storacha/w3ui@654d507))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasco-santos vasco-santos vasco-santos approved these changes

@alanshaw alanshaw Awaiting requested review from alanshaw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugomrdias @vasco-santos