Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(capabilities): implement access/authorize and ./update caps #387

Merged
merged 2 commits into from
Jan 25, 2023
Merged

feat(capabilities): implement access/authorize and ./update caps #387

merged 2 commits into from
Jan 25, 2023

Conversation

hugomrdias
Copy link
Contributor

closes #385

@hugomrdias hugomrdias changed the title feat(capabilities): implement access caps feat(capabilities): implement access/authorize and ./update caps Jan 23, 2023
Gozala
Gozala approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@Gozala Gozala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Fact that ./update is in access/* made me bit uncomfortable, don't know why, perhaps because it feels less special. That said I don't have any better ideas where to put it so this seems fine to me.

Gozala
Gozala reviewed Jan 24, 2023
View reviewed changes
packages/capabilities/src/access.js
export const session = capability({
can: './update',
// Should be web3.storage DID
with: URI.match({ protocol: 'did:' }),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be DID.match({ method: 'web' }) instead or perhaps even a Schema.literal('did:web:web3.storage') ?

@hugomrdias hugomrdias merged commit 4242ce0 into main Jan 25, 2023
@hugomrdias hugomrdias deleted the feat/access-authorize-cap branch January 25, 2023 10:30
@hugomrdias hugomrdias mentioned this pull request Jan 25, 2023
Merged
hugomrdias added a commit that referenced this pull request Jan 31, 2023
@hugomrdias
chore(main): release capabilities 2.2.0 (#299)
a58a749 
🤖 I have created a release *beep* *boop*
---


##
[2.2.0](capabilities-v2.1.0...capabilities-v2.2.0)
(2023-01-30)


### Features

* access-api forwards store/ and upload/ invocations to upload-api
([#334](#334))
([b773376](b773376))
* **capabilities:** implement access/authorize and ./update caps
([#387](#387))
([4242ce0](4242ce0)),
closes [#385](#385)
* embedded key resolution
([#312](#312))
([4da91d5](4da91d5))
* update @ucanto/* to ~4.2.3
([#405](#405))
([50c0c80](50c0c80))
* update access-api ucanto proxy to not need a signer
([#390](#390))
([71cbeb7](71cbeb7))


### Bug Fixes

* fix client cli service did resolve
([#292](#292))
([6be9608](6be9608))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
gobengo pushed a commit that referenced this pull request Apr 11, 2023
@hugomrdias
feat(capabilities): implement access/authorize and ./update caps (#387)
ebe1032 
closes #385
gobengo pushed a commit that referenced this pull request Apr 11, 2023
@hugomrdias
chore(main): release capabilities 2.2.0 (#299)
37b7ca1 
🤖 I have created a release *beep* *boop*
---


##
[2.2.0](capabilities-v2.1.0...capabilities-v2.2.0)
(2023-01-30)


### Features

* access-api forwards store/ and upload/ invocations to upload-api
([#334](#334))
([6be7217](6be7217))
* **capabilities:** implement access/authorize and ./update caps
([#387](#387))
([ebe1032](ebe1032)),
closes [#385](#385)
* embedded key resolution
([#312](#312))
([45f367d](45f367d))
* update @ucanto/* to ~4.2.3
([#405](#405))
([ec39443](ec39443))
* update access-api ucanto proxy to not need a signer
([#390](#390))
([163fb74](163fb74))


### Bug Fixes

* fix client cli service did resolve
([#292](#292))
([45e7ad4](45e7ad4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 17, 2025
@github-actions
chore(main): release keyring-core 2.2.1 (storacha#387)
73a061a 
🤖 I have created a release *beep* *boop*
---


##
[2.2.1](storacha/w3ui@keyring-core-v2.2.0...keyring-core-v2.2.1)
(2023-02-22)


### Bug Fixes

* update to latest @web3-storage/access
([storacha#384](storacha/w3ui#384))
([5b06ee5](storacha/w3ui@5b06ee5))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 29, 2025
@github-actions
chore(main): release keyring-core 2.2.1 (storacha#387)
130c702 
🤖 I have created a release *beep* *boop*
---


##
[2.2.1](storacha/w3ui@keyring-core-v2.2.0...keyring-core-v2.2.1)
(2023-02-22)


### Bug Fixes

* update to latest @web3-storage/access
([storacha#384](storacha/w3ui#384))
([ad2844e](storacha/w3ui@ad2844e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gozala Gozala Gozala approved these changes

@alanshaw alanshaw Awaiting requested review from alanshaw

@gobengo gobengo Awaiting requested review from gobengo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement access/authorize cap
2 participants
@hugomrdias @Gozala