Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/credentials: update test password #96

Merged
merged 2 commits into from
Feb 27, 2024
Merged

cmd/credentials: update test password #96

merged 2 commits into from
Feb 27, 2024

Conversation

mobyvb
Copy link
Member

@mobyvb mobyvb commented Feb 21, 2024

The required minimum length for passwords on the satellite will change from 6 to 8. This change uses "password" (8 chars) instead of "123a123" (7 chars).

The required minimum length for passwords on the satellite will change
from 6 to 8. This change uses "password" (8 chars) instead of "123a123"
(7 chars).
@mobyvb mobyvb requested a review from elek as a code owner February 21, 2024 22:12
@dlamarmorgan
Copy link
Collaborator

Does the password used in pkg/common/apikey.go also need to be updated for this?

@mobyvb
Copy link
Member Author

mobyvb commented Feb 22, 2024

@dlamarmorgan I thought about that, but I don't think so. We don't do validation on user-managed encryption passphrase, and it is not affected by my changes in storj/storj
However, I can update that one too for consistency if you'd like.

@mobyvb
Copy link
Member Author

mobyvb commented Feb 26, 2024

@dlamarmorgan I went ahead and updated the passphrase for the api key - I ended up doing that in storj/storj anyway

@dlamarmorgan dlamarmorgan self-requested a review February 27, 2024 15:03
@dlamarmorgan dlamarmorgan merged commit fd6c701 into main Feb 27, 2024
2 checks passed
@dlamarmorgan dlamarmorgan deleted the credentials branch February 27, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants