Add use https option #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stormcat24 Please let me know if you have any concerns about this PR. 😃 |
|
@stormcat24 I'd love to see this in protodep too. The ssh identify setup doesn't really work for multiple users in a team that may not have the identity setup for repos. |
|
IMO shelling out to git is probably a better option and falling back to this logic in case git is missing (but imo it shouldn't be a big deal to say "depends on Git in PATH"). |
|
@mmlb Sorry for the late reply 🙏 |
Merged
|
props go to @ackintosh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #45
Added a CLI flag to clone dependencies via HTTPS.