Add Heading component #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nick-StormID
approved these changes
Dec 6, 2021
|
A bit more context - role=text is non-spec (it didn't make it into aria 1.1 but was discussed in detail but things got complicated especially around which elements it would be allowed on), and it fails automated tests in axe-core pre version 4.2 (which means current Lighthouse will flag it, as well as many other tools). NHS design system decided to use it regardless, and the exception has been added to axe-core in 4.2. dequelabs/axe-core#1597 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a Heading component that accepts a level and className props.
The component checks if there are child element nodes and adds a wrapper span[role="text"] to improve screen reader announcements.
Full description in #98