Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Publish ESM #3

Open
IanVS opened this issue Apr 11, 2022 · 1 comment
Open

[Feature] Publish ESM #3

IanVS opened this issue Apr 11, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@IanVS
Copy link
Member

IanVS commented Apr 11, 2022

Describe the bug

I'm attempting to use @storybook/bench for vite-builder projects, but I get a failure of ReferenceError: exports is not defined for this plugin's preview.js file. I'm trying to find a way to optimize it back from cjs to esm, but I think it would be good if this addon also exported ESM so that isn't necessary.
@IanVS IanVS added the enhancement New feature or request label Apr 11, 2022
@IanVS
Copy link
Member Author

IanVS commented Apr 11, 2022

Turns out this was due to a bug in the vite builder, which will be fixed by storybookjs/builder-vite#332. Still might be nice to have some esm, but it's not crucial for what I'm doing right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@IanVS