Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid @fs imports for storyStoreV7 #332

Merged
merged 1 commit into from
Apr 11, 2022
Merged

Avoid @fs imports for storyStoreV7 #332

merged 1 commit into from
Apr 11, 2022

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented Apr 11, 2022

Similar to #324, this avoids the use of /@fs/ imports in the modern loader, with storyStoreV7 enabled.

To test, use the react-ts example, install @storybook/addon-bench, add it to the addons list in main.js, and try starting storybook. It will fail in main, but pass in this branch.

@IanVS IanVS merged commit 96561c2 into main Apr 11, 2022
@IanVS IanVS deleted the avoid-fs-import-modern branch April 11, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants