Improving maintainability: run lint
#196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 6, 2022
mrauhu
force-pushed
the
improving-maintainability/run-lint
branch
3 times, most recently
from
5e7fe98 to
a8a5be0
Compare
|
Thanks for this, I will review it after #193 is merged, since it is difficult right now to tell what's a part of this PR and what's a part of the other. |
5 tasks
…HtmlUnknownTarget` and `noinspection CssUnusedSymbol` # Conflicts: # packages/storybook-builder-vite/input/iframe.html
…script.ts`. TODO: Inline variable and remove `noinspection`. We are using `/** */` comment between `//` comments, because it's only way to make work both JetBrains IDE comments.
# Conflicts: # packages/storybook-builder-vite/index.js
…e-script.ts` file
…frameScriptCode()` function
… in the server watcher change callback of `configureServer()` function
For using it, run one time: ``` git config blame.ignoreRevsFile .git-blame-ignore-revs ```
mrauhu
force-pushed
the
improving-maintainability/run-lint
branch
from
a8a5be0 to
b65b20f
Compare
|
Rebased onto |
|
We will need to change the SHA in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
This pull request is part of #188.
Resolves #193 (comment).
Done:
linton all codebase.packages/storybook-builder-vitedirectory..git-blame-ignore-revsfile.@eirslett, @IanVS
For setup, run once:
Also, you can enable the
Hide whitespace changesoption in theFiles changedtab settings.Best wishes,
Sergey.