Fix react mdx stories #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
joshwooding
approved these changes
Jun 22, 2022
|
Thanks for digging into this! |
|
No problem @maxbeatty. I could still use help figuring out why the styling isn't working correctly in the preact example mdx story. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where as long as preact is installed in the monorepo, vite-plugin-mdx will default to using it, even in react projects, causing an error in mdx stories.
This uses the
frameworkoption, and only uses the preact mdx if the framework is preact, otherwise falling back to react. This was enabled by brillout/vite-plugin-mdx@b37e2cd.I also added an mdx story in the preact example, but the styling is wrong. @maxbeatty do you know why that might be? Does storybook's emotion need to be configured to work with preact, maybe?
To test, verify that the
introductionstory is working in the react example as well as the preact example, and maybe vue too, for good measure.