Remove mock-core-js plugin #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshwooding
approved these changes
Jul 25, 2022
|
I think just removing the plugin wasn't enough to solve the problem similar to one outlined in #143. In my case I also had to add |
|
I think the problem was that core-js code is in CommonJS format, so it had to be either preoptimized (in particular: every single import path from core-js, so it would be a very long list of imports) or mocked away. Maybe things have changed with later versions of Vite? If everything works as it should without mock-core-js then I'm sure it's better to just remove it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #143
Fixes #412
Fixes #448
I'm not sure why this plugin is here, but it seems to cause problems according to the issues mentioned here, and those problems are solved when this plugin is removed. Maybe older versions of vite could not handle core-js? @eirslett do you remember why you added this mock?
At any rate, since several folks have reported success when removing the plugin, let's just take it out. If we hear it causes problems for others, we can investigate further what's going on.